Add polling throttle test and document timeout logic#51
Closed
Add polling throttle test and document timeout logic#51
Conversation
Add a test that verifies GET request count stays bounded during polling (< 15 over 500ms, vs 50+ without throttle). Add a comment to the read function explaining the polling strategy. Also clean up client_test.clj to follow Clojure testing conventions: group related assertions under testing blocks, extract with-client macro to reduce boilerplate, make helpers private, use clojure.string/starts-with? over Java interop.
bbatsov
added a commit
that referenced
this pull request
Feb 19, 2026
Add a test that verifies GET request count stays bounded during polling (< 15 over 500ms, vs 50+ without throttle). Add a comment to the read function explaining the polling strategy. Also clean up client_test.clj to follow Clojure testing conventions: group related assertions under testing blocks, extract with-client macro to reduce boilerplate, make helpers private, use clojure.string/starts-with? over Java interop. Fixes #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to the GET flood fix (8663445). Adds a test that spins up a
server with a request counter and verifies GET polling stays bounded
(< 15 requests over a 500ms window). Also adds a comment to the read
function explaining the polling strategy and the 100ms backoff cap.
Fixes #10