fix: resolve #95 — Add Regular (cached) pinned memory allocation strategy#213
Open
ed-thuando wants to merge 2 commits into
Open
Conversation
…ation strategy Fixes novitalabs#95 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
…ation strategy Fixes novitalabs#95 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
jimmy-evo
requested changes
Apr 17, 2026
| } | ||
| } | ||
| } | ||
| }l(size: usize, strategy: AllocStrategy) -> Result<Self, PinnedMemError> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #95 — Add Regular (cached) pinned memory allocation strategy
Problem
Severity:
High| File:pegaflow-core/src/pinned_mem.rsContains the AllocStrategy enum and PinnedMemory::allocate function. Currently has WriteCombined and HugePages variants. Need to add Regular variant that uses cudaHostAllocDefault for bidirectional workloads where CPU cache matters.
Solution
Add
Regularvariant to AllocStrategy enum and update theallocatefunction to handle the new variant by calling cudaHostAllocDefault instead of cudaHostAllocWriteCombined or mmap with MAP_HUGETLB.Changes
pegaflow-core/src/pinned_mem.rs(modified)pegaflow-core/src/pinned_pool.rs(modified)Testing
Generated by ContribAI v6.0.0