-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
buffer: add Buffer.fromHex() and Buffer.fromBase64()
#61157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
buffer: add Buffer.fromHex() and Buffer.fromBase64()
#61157
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61157 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 703 703
Lines 208589 208617 +28
Branches 40226 40223 -3
=======================================
+ Hits 184650 184685 +35
+ Misses 15954 15952 -2
+ Partials 7985 7980 -5
🚀 New features to boost your workflow:
|
|
Remember to update the docs |
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this is missing a doc entry, LGTM
|
Agreed, added to the docs. |
These methods are already present on
Uint8Array, so without defining them onBufferthey return instances ofUint8Array. This introduces wrapper to return instances ofBufferinstead.Fixes: #61146