system_monitor_service: add Tctl to the list of valid CPU temp labels#3002
Closed
LionHeartP wants to merge 1 commit into
Closed
system_monitor_service: add Tctl to the list of valid CPU temp labels#3002LionHeartP wants to merge 1 commit into
LionHeartP wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR and the report. As discussed on discord, I went another direction after gathering all the data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Tctl to the list of valid CPU temp labels
Motivation
On my system, I have no Tdie sensor. The fallback to any "CPU" label that exists can poll the wrong sensor resulting in 0C or invalid readings overall
Type of Change
Testing
Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.Additional Notes