[single] Introduce _is_valid_extension helper to simplify model validation #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
songgot
commented
Nov 19, 2025
songgot
commented
- Extracted the file extension checking logic into a new static helper function
songgot
requested review from
again4you,
anyj0527,
gichan-jang,
jaeyun-jung and
myungjoo
as code owners
myungjoo
approved these changes
Nov 19, 2025
songgot
force-pushed
the
add_helper_to_check_valid_extension
branch
2 times, most recently
from
5379b05 to
26d7371
Compare
jaeyun-jung
approved these changes
Nov 27, 2025
…ation - Extracted the file extension checking logic into a new static helper function Signed-off-by: hyunil park <[email protected]>
songgot
force-pushed
the
add_helper_to_check_valid_extension
branch
from
b558e39 to
1e34f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.