fix: take liquidity when an L3 order is modified to a marketable price - #322
Open
23f3001135 wants to merge 1 commit into
Open
fix: take liquidity when an L3 order is modified to a marketable price#32223f3001135 wants to merge 1 commit into
23f3001135 wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a resting L3 order is modified to a price that crosses the book, such as a buy order with a price greater than or equal to the best ask, or a sell order with a price less than or equal to the best bid, it must take liquidity rather than remain at a crossed price in the queue.
L3NoPartialFillExchange::ack_modifynow detects a marketable modification and cancels and resubmits the order, resettingleaves_qtyto the newqty.This mirrors the behavior of the L2
NoPartialFillExchange, where an order modification is handled as a cancellation followed by a new order.When the original order no longer exists because it was filled, expired, or has an unknown ID, the modification is rejected using the existing
OrderNotFoundpath.Tests
Added unit tests covering:
Test command:
cargo test -p hftbacktest --no-default-features --features backtestAll 25 tests pass.