-
Notifications
You must be signed in to change notification settings - Fork 92
feat: implement inbound roaming reject #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,6 +79,15 @@ hss: | |
| - 'scscf.ims.mnc001.mcc001.3gppnetwork.org' | ||
|
|
||
| roaming: | ||
| inbound: | ||
| # How to handle unknown IMSIs when inbound roaming. Valid options are: | ||
| # IMSI_UNKNOWN - Reject the request with the "IMSI_UNKNOWN" error code. | ||
| # ROAMING_NOT_ALLOWED - Reject the request with the "ROAMING_NOT_ALLOWED" error code. | ||
| # The latter is useful when operating a private network and public SIMs should not be allowed to connect. | ||
| # "Roaming not allowed" will cause the UE to not try again on this network. | ||
| # "Imsi unknown" may cause the UE to believe that its subscription is invalid. | ||
| # For private networks, "ROAMING_NOT_ALLOWED" is recommended. Otherwise, use "IMSI_UNKNOWN". | ||
| reject_unknown_imsis_with: "ROAMING_NOT_ALLOWED" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be too much for this pull request, so feel free to reject the idea. But how about we check if this config option (and in the future: more config options) doesn't have an unexpected value set at the start of the main service of PyHSS and refuse to start up if that is the case? This would prevent users from accidentally making a typo in the config value and then possibly running with the wrong reject unknown setting.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about this some more, it should be easy to add such a check in
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've had the same thought the other day. I think I will just go ahead and add this to this PR as it should not be a big deal. |
||
| outbound: | ||
| # Whether or not to a subscriber to connect to an undefined network when outbound roaming. | ||
| allow_undefined_networks: True | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about mentioning in
CHANGELOG.mdbetween## [Unreleased]and### Addedthat users may want to adjust their config to addreject_unknown_imsis_with: "ROAMING_NOT_ALLOWED"if they are running a private network?