nirfsg: Add get_script and delete_script APIs #2169
nirfsg: Add get_script and delete_script APIs #2169
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (23.80%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
- Coverage 90.13% 89.98% -0.15%
==========================================
Files 71 71
Lines 18669 18711 +42
==========================================
+ Hits 16827 16838 +11
- Misses 1842 1873 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
vnktshr21
left a comment
There was a problem hiding this comment.
List down the newly added APIs in PR description and update changelog as well.
| end script''' | ||
| rfsg_device_session.write_script(script_content) | ||
| retrieved_script = rfsg_device_session.get_script('myScript1') | ||
| assert retrieved_script is not None |
There was a problem hiding this comment.
why not assert whole script match?
| 'value': 'sparameterTableSize' | ||
| }, | ||
| 'type': 'NIComplexNumber[]', | ||
| 'type': 'NIComplexNumber[][]', |
| }, | ||
| 'is_repeated_capability': True, | ||
| 'name': 'triggerId', | ||
| 'grpc_enum': 'DigitalEdgeScriptTriggerIdentifier', |
There was a problem hiding this comment.
are these safe to be removed from grpc support perspective?
What does this Pull Request accomplish?
This PR adds below APIs to nirfsg:
get_script(script_name)- Retrieves the content of a compiled script by namedelete_script(script_name)- Deletes a script from memoryList issues fixed by this Pull Request below, if any.
What testing has been done?
test_get_scriptandtest_delete_scriptfor recently addedget_scriptanddelete_scriptAPIs and these tests are passing on real hardware. These are expected to be skipped on simulated devices.