Conversation
41588c0 to
6b87094
Compare
| { | ||
| "name": "@ni/nimble-angular", | ||
| "version": "32.3.4", | ||
| "version": "33.0.0", |
There was a problem hiding this comment.
I temporarily did a manual major version bump to ensure no published version gets installed over these while validation testing.
Need to revert each package's version before submitting.
jattasNI
left a comment
There was a problem hiding this comment.
I did a quick manual scan of the Angular example app and everything looked unchanged 👍
Update looks good to me, just waiting to approve so I can take another look when the release train starts.
| "ng-packagr": "^20.3.2", | ||
| "playwright": "1.54.1", | ||
| "rollup": "^4.12.0", | ||
| "typescript": "~5.8.3" |
There was a problem hiding this comment.
What's your policy for deciding whether to update the typescript version? I noticed that you'd bumped it for Angular 19 but not for 20. #2786.
In Angular's version compatibility table it says we could bump to 5.9.x if we wanted. But if our historic policy is to only upgrade when needed, I'm fine with keeping that.
There was a problem hiding this comment.
Yes, I've typically not upgraded anything else significant (like typescript) unless I had to. If something stops working, it would be nice to have fewer things to have to consider.
There was a problem hiding this comment.
Agree that it shouldn't be done in the Angular upgrade PR unless absolutely necessary, but we should consider upgrading the TypeScript versions everywhere (i.e. including ni/fast) to be part of the Angular upgrade process (as follow-up PRs) so it's done consistently and since it is bounded by Angular.
6dbb234 to
8441eac
Compare
8441eac to
2bee149
Compare
rajsite
left a comment
There was a problem hiding this comment.
Looks like the thirdparty directory forks where a pain this time around. Thanks for the thorough approach, looks good!
Pull Request
🤨 Rationale
Fixes #2829
👩💻 Implementation
eslint-config-angularversionpackages/angular-workspace/nimble-angular/thirdparty🧪 Testing
Automated tests pass.