Update read_data to call into read_measurement_value and read_condition_value.#120
Draft
mjohanse-emr wants to merge 10 commits intomainfrom
Draft
Update read_data to call into read_measurement_value and read_condition_value.#120mjohanse-emr wants to merge 10 commits intomainfrom
mjohanse-emr wants to merge 10 commits intomainfrom
Conversation
…alue Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Collaborator
Author
|
I'm going to close this PR temporarily. Johann and I discussed an alternative that I'm going to try out, so I don't want y'all to waste time reviewing this in the current state. |
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
commented
Mar 12, 2026
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Replaces the
read_datamethod in thedatastore-pythonpackage with these new read entrypoints:read_measurement_valueread_condition_valueThese read methods no longer uses the
MonikerandMonikerClientto perform the read. It simply calls the lower levelread_measurement_valueorread_condition_valuewith theidfrom thePublishedMeasurementorPublishedCondition.Tests and examples have been updated to use these new read methods.
All usage, documentation, and testing of
MonikerandMonikerClienthas been scrubbed from this python package.I bumped the version to 2.0.0 since there are breaking changes to the read methods in this PR.
Why should this Pull Request be merged?
AB#3712177
We want
datastore-pythonto use the newidbased read entrypoints.We want
datastore-pythonto have similarly named read methods to the C# API.What testing has been done?
All acceptance and unit tests pass.