Bugfix/6371/fix hyperlinks with numbers#6392
Open
mahibi wants to merge 2 commits into
Open
Conversation
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
…erlink The mask-based Linkify.addLinks(PHONE_NUMBERS|EMAIL_ADDRESSES) call stripped all existing URLSpans before adding its own, so phone/email spans could land inside markdown link text or plain URLs containing digit sequences. Tapping those digits then opened the phone dialer instead of the hyperlink. Replace the destructive mask-based call with three pattern-based calls (URLs first, then phone and email). A MatchFilter rejects any match whose range is already covered by a URLSpan, which includes Markwon's LinkSpan (markdown links) since LinkSpan extends URLSpan. This removes the need for the save/restore workaround entirely. Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
rapterjet2004
requested changes
Jun 25, 2026
rapterjet2004
left a comment
rapterjet2004
left a comment
Contributor
There was a problem hiding this comment.
Doesn't seem to be working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6371
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)