-
Notifications
You must be signed in to change notification settings - Fork 112
Added RTL to forms front when using ?forceLanguage=he
#3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please see my comments about the translations
Also please fix Lint and DCO workflows :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these changes and add them on Transifex. Translations must never be changed directly in the code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these changes and add them on Transifex. Translations must never be changed directly in the code :)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Lint problems in unchanged files, so you can fix it by yourself. About Transifex - not familiar with it. Please send manual how to add translation strings. |
|
@andreydruz the lint errors come clearly from your commit :) Regarding the translations: just remove the changes from your commit. They need to be done on Transifex, which is a separate application/portal. I don't know if for your language there are already some translators active. Perhaps @rakekniven can have a look |
Added new Hebrew translations for form interactions and error messages
Hello, Deleted translation files. |
Added new Hebrew translations for form interactions and error messages