Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Oct 28, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Oct 28, 2022
iossifbenbassat123 and others added 29 commits October 30, 2025 09:53
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
[CI] Merge self-upgrade-master into master
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
Co-authored-by: Richard Wall <[email protected]>
Signed-off-by: iossifbenbassat123 <[email protected]>
Signed-off-by: Iossif Benbassat <[email protected]>
…b-actions

chore(deps): update github/codeql-action action to v4.31.2 (master)
…onsi-deps

fix(deps): update module github.com/onsi/ginkgo/v2 to v2.27.2 (master)
Signed-off-by: Erik Godding Boye <[email protected]>
adds logs for cases when acme server return us fatal error
Signed-off-by: Tim Ramlot <[email protected]>
cert-manager-prow bot and others added 30 commits December 17, 2025 17:48
…b-actions

chore(deps): update github/codeql-action action to v4.31.9 (master)
[CI] Merge self-upgrade-master into master
…-sigs-kind-0.x

chore(deps): update dependency kubernetes-sigs/kind to v0.31.0 (master)
… ingress/gateway-api change should trigger a certificate update

Signed-off-by: Eleanor Merry <[email protected]>
Signed-off-by: Eleanor Merry <[email protected]>
venafi: Process custom fields annotations on Issuer
… controller (#8312)

* Add configurable initial certificate request backoff

- Add controller config field for initial certificate request backoff
- Add CLI flag to configure the initial backoff duration
- Use configured initial delay in trigger controller backoff
- Default initial delay is 1h and backoff doubles per failure up to 32h
- Update defaults, conversions, controller context, and tests

Signed-off-by: Hemant Joshi <[email protected]>
Co-authored-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>

* attempt to fix test with default backoff

Signed-off-by: hjoshi123 <[email protected]>

---------

Signed-off-by: Hemant Joshi <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: hjoshi123 <[email protected]>
Co-authored-by: Richard Wall <[email protected]>
* BOT: run 'make upgrade-klone' and 'make generate'

Signed-off-by: cert-manager-bot <[email protected]>

* fix(deps): update kubernetes go deps to v0.35.0

Signed-off-by: Renovate Bot <[email protected]>

* Fix some failing tests

Signed-off-by: Erik Godding Boye <[email protected]>

* Disable WatchListClient feature gate in tests for now

Signed-off-by: Erik Godding Boye <[email protected]>

* Partially reverted "Fix some failing tests"

This partially reverts commit b340bd0.

Signed-off-by: Tim Ramlot <[email protected]>

---------

Signed-off-by: cert-manager-bot <[email protected]>
Signed-off-by: Renovate Bot <[email protected]>
Signed-off-by: Erik Godding Boye <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Co-authored-by: cert-manager-bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tim Ramlot <[email protected]>
[CI] Merge self-upgrade-master into master
…n-ingresses

Add checks for Duration/RenewBefore changes when determining if an ingress/gateway-api change should trigger a certificate update
fix(deps): update module software.sslmate.com/src/go-pkcs12 to v0.7.0 (master)
[CI] Merge self-upgrade-master into master
fix: update helm install NOTES to include GWAPI instructions
Signed-off-by: Hemant Joshi <[email protected]>
fix(ci): adding 1.35 kind version
* adding labels to lease

Signed-off-by: hjoshi123 <[email protected]>
Signed-off-by: Hemant Joshi <[email protected]>

* Update cmd/cainjector/app/controller.go

Co-authored-by: Erik Godding Boye <[email protected]>
Signed-off-by: Hemant Joshi <[email protected]>

---------

Signed-off-by: hjoshi123 <[email protected]>
Signed-off-by: Hemant Joshi <[email protected]>
Signed-off-by: Hemant Joshi <[email protected]>
Co-authored-by: Erik Godding Boye <[email protected]>
Vault's JWT/OIDC authentication requires "bound_audiences" to be set and
match at least one of the audiences on the JWT. This is in contrast to
Vault's Kubernetes authentication method in which "bound_audiences" is
optional. In addition, the "bound_audiences" configuration is static.

As "bound_audiences" is required with the JWT/OIDC method, the
per-issuer audience generated by cert-manager was difficult to use in
common use cases. Either the Vault operator must define new Vault role
bindings for every combination of namespace and issuer names, or every
issuer must be created with a static issuer defined. Switching from the
Kubernetes method to the JWT/OIDC method would also require every issuer
to be updated with the audience.

This changeset adds the value of the issuer's ".spec.vault.server" to
the default audience list. This gives the Vault operator a static value
to define for "bound_audiences".

Bug: #8218
Signed-off-by: Terin Stock <[email protected]>
feat(vault): add server as default audience
Add unhealthyPodEvictionPolicy to supported PDB options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.