Skip to content

feat: add nrgorm apm integration#994

Open
XiXiangFiles wants to merge 2 commits into
newrelic:developfrom
XiXiangFiles:feat-nrgorm
Open

feat: add nrgorm apm integration#994
XiXiangFiles wants to merge 2 commits into
newrelic:developfrom
XiXiangFiles:feat-nrgorm

Conversation

@XiXiangFiles

@XiXiangFiles XiXiangFiles commented Jan 24, 2025

Copy link
Copy Markdown

Links

#993

Details

I use the Gorm plugin to achieve the desired APM effect.

@CLAassistant

CLAassistant commented Jan 24, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ XiXiangFiles
❌ jerry.wang


jerry.wang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nr-swilloughby nr-swilloughby changed the base branch from master to develop January 30, 2025 00:10
@nr-swilloughby

Copy link
Copy Markdown
Contributor

Thank you for contributing your PR. Please note that we can't proceed until the contributor license agreement has been signed. We'll also need to review the feature request for consideration to add the integration to the APM product and may potentially make further modifications as may be necessary to fully integrate it to the agent's architectural design as recommended by the review, assuming all of the above is approved.

@iamemilio

Copy link
Copy Markdown
Contributor

@XiXiangFiles Would it be possible to add some unit tests to this PR?

@mirackara

Copy link
Copy Markdown
Contributor

Hey @XiXiangFiles

This PR has aged a bit. Checking in to see if you had any uncommited changes (unit testing) we can in so we can give this a merge.

Thanks!

@XiXiangFiles

Copy link
Copy Markdown
Author

@mirackara Unit tests have been added. Could you help take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants