feat instrument pgx CopyFrom#826
Open
vinicius-batista wants to merge 1 commit into
Open
Conversation
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #826 +/- ##
===========================================
+ Coverage 80.06% 80.37% +0.30%
===========================================
Files 136 138 +2
Lines 12358 12489 +131
===========================================
+ Hits 9895 10038 +143
+ Misses 2180 2169 -11
+ Partials 283 282 -1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
|
Thanks for your PR. We'll review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
Closes #825
Details
The implementation and tests was simple but I have a problem running tests when snapshot was already created.
The current installed version from
pgsnapfails when readCopyDatafrom snapshot.At pgsnap's latest version CopyData and other messages were implemented but pgproto is failing to unmarshal
CopyInResponsemessage.I don't know how to proceed with this implementation as some tests are failing due to external dependencies.