Skip to content

feat instrument pgx CopyFrom#826

Open
vinicius-batista wants to merge 1 commit into
newrelic:developfrom
vinicius-batista:feature/instrument-copy-from-pgx5
Open

feat instrument pgx CopyFrom#826
vinicius-batista wants to merge 1 commit into
newrelic:developfrom
vinicius-batista:feature/instrument-copy-from-pgx5

Conversation

@vinicius-batista

Copy link
Copy Markdown

Links

Closes #825

Details

The implementation and tests was simple but I have a problem running tests when snapshot was already created.
The current installed version from pgsnap fails when read CopyData from snapshot.
At pgsnap's latest version CopyData and other messages were implemented but pgproto is failing to unmarshal CopyInResponse message.

I don't know how to proceed with this implementation as some tests are failing due to external dependencies.

@CLAassistant

CLAassistant commented Nov 23, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vinicius-batista

Copy link
Copy Markdown
Author

@iamemilio

@iamemilio iamemilio self-requested a review November 27, 2023 18:31
@codecov-commenter

codecov-commenter commented Nov 27, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.37%. Comparing base (d752b7e) to head (dc1ed85).
⚠️ Report is 395 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
+ Coverage    80.06%   80.37%   +0.30%     
===========================================
  Files          136      138       +2     
  Lines        12358    12489     +131     
===========================================
+ Hits          9895    10038     +143     
+ Misses        2180     2169      -11     
+ Partials       283      282       -1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d752b7e...dc1ed85. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nr-swilloughby

Copy link
Copy Markdown
Contributor

Thanks for your PR. We'll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants