Bug Fix: Remove ‘past’ dependency from fssd.py and test_density.py (#423)#428
Open
manuelarceaguirre wants to merge 1 commit intoneurodata:mainfrom
Open
Conversation
…vision in simulate_null_dist
✅ Deploy Preview for hyppo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Thank you for your contribution! Changes look good to me. Once the tests pass, I will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #423. Removed
past.utils.old_divfromfssd.pyandtest_density.pyto eliminateModuleNotFoundErrorin Python 3.9+. Replacedold_divwith/, and adjustedsimulate_null_distinfssd.pyto use integer division (//) to fix aTypeErrorin tests. Verified locally withpytest hyppo/kgof/tests/—all 12 tests passed on Python 3.12.Changes:
fssd.py: Removedfrom past.utils import old_div, replaced 8old_divinstances with/, fixedd = len(eigs) / Jtod = len(eigs) // J.test_density.py: Removedfrom past.utils import old_div, replaced 2old_divinstances with/.python -m pytest hyppo/kgof/tests/shows 12/12 passed.