Conversation
added 3 commits
May 8, 2026 20:46
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SSL issuance and Nginx HTTPS listener configuration, plus refreshes DockerHub workflow action versions for building/pushing images.
Changes:
- Skip
ACME_DOMAINSentries containing wildcard (*) during SSL issuance inupdatessl.sh. - Adjust Nginx template to enable HTTP/2 via
http2 on;rather than thelisten ... http2parameter. - Bump Docker GitHub Actions used in the DockerHub workflow to newer major versions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| updatessl.sh | Adds logic intended to skip wildcard domain entries during certificate issuance. |
| nginx.tmpl | Changes how HTTP/2 is enabled for HTTPS listeners across several server blocks. |
| .github/workflows/dockerhub.yml | Updates Docker-related GitHub Actions versions for multi-arch builds/pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if grep ACME_DOMAINS $DEFAULT_CONF ; then | ||
| for d_list in $(grep ACME_DOMAINS $DEFAULT_CONF | cut -d ' ' -f 2); | ||
| do | ||
| if echo "$d_list" | grep '*'; then |
| {{ if $enable_ipv6 }} | ||
| listen [::]:{{ $external_https_port }} ssl http2; | ||
| listen [::]:{{ $external_https_port }} ssl; | ||
| http2 on; |
Comment on lines
+367
to
376
| listen {{ $external_https_port }} ssl {{ $default_server }}; | ||
| http2 on; | ||
| {{ if eq $enable_socks "true" }} | ||
| listen unix:/etc/nginx/socks/{{ $host }}.{{ $external_https_port }}.sock ssl http2 {{ $default_server }}; | ||
| listen unix:/etc/nginx/socks/{{ $host }}.{{ $external_https_port }}.sock ssl {{ $default_server }}; | ||
| http2 on; | ||
| {{ end }} | ||
| {{ if $enable_ipv6 }} | ||
| listen [::]:{{ $external_https_port }} ssl http2 {{ $default_server }}; | ||
| listen [::]:{{ $external_https_port }} ssl {{ $default_server }}; | ||
| http2 on; | ||
| {{ end }} |
Comment on lines
+496
to
505
| listen {{ $external_https_port }} ssl {{ $default_server }}; | ||
| http2 on; | ||
| {{ if eq $enable_socks "true" }} | ||
| listen unix:/etc/nginx/socks/{{ $host }}.{{ $external_https_port }}.sock ssl http2 {{ $default_server }}; | ||
| listen unix:/etc/nginx/socks/{{ $host }}.{{ $external_https_port }}.sock ssl {{ $default_server }}; | ||
| http2 on; | ||
| {{ end }} | ||
| {{ if $enable_ipv6 }} | ||
| listen [::]:{{ $external_https_port }} ssl http2 {{ $default_server }}; | ||
| listen [::]:{{ $external_https_port }} ssl {{ $default_server }}; | ||
| http2 on; | ||
| {{ end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.