Conversation
added 2 commits
May 8, 2026 20:46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SSL renewal script to skip wildcard (*) domain entries when iterating ACME_DOMAINS, and bumps Docker-related GitHub Actions used by the DockerHub publishing workflow to newer major versions.
Changes:
- Skip
ACME_DOMAINSentries containing*inupdatessl.sh. - Update
docker/*GitHub Actions major versions in the DockerHub workflow (metadata, qemu, buildx, login, build-push).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
updatessl.sh |
Adds a guard intended to skip wildcard domains during certificate issuance. |
.github/workflows/dockerhub.yml |
Bumps Docker GitHub Actions major versions used to build/push multi-arch images. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+20
| if echo "$d_list" | grep '*'; then | ||
| continue; | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.