Optional Icon Block integration (dual source, preset grid preserved) - #5
Open
jrevillini wants to merge 1 commit into
Open
Optional Icon Block integration (dual source, preset grid preserved)#5jrevillini wants to merge 1 commit into
jrevillini wants to merge 1 commit into
Conversation
Preserve preset grid; dual iconSource storage; toolbar bolt picker. See docs/ARCHITECTURE.md and docs/ICON_SOURCE_TEST_CHECKLIST.md.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional The Icon Block bridge for
core/button:@icon-blockat build time).iconSourceselects display.ebiIconwhen Icon Block is not active.Relates to #2 — happy to collaborate or supersede that branch if this direction fits better.
Why this vs #2
iconSource+ sidebar ResetDocumentation
docs/ARCHITECTURE.mddocs/ICON_SOURCE_TEST_CHECKLIST.mdicon-blocksibling,npm install && npm run build(see README)Demo
Test plan
ebiIcon; editor warning; presets workiconslug unchangednpm run buildclean with Icon Block clone at../icon-blockDiff notes
20 file pairs differ (see manifest.txt)
Branch:
feature/icon-block-integration· Generated 2026-05-23T11:54:53Z