Feature: Update API search collection test for renamed Solr collections#207
Merged
Conversation
Expect the admin search collections endpoint to report the physical Solr bootstrap collections, term_search_bootstrap and property_search_bootstrap, while allowing the stable term_search and property_search aliases as additional entries.
…cbo/ontologies_api into feature/solrcloud-alias-indexing-codex
Point the API stack at the latest GOO and related Solr alias commits, including the GOO test cleanup that prevents leaked search collections from breaking API collection assertions.
Point the API stack at the latest GOO, OLD, and ncbo_cron commits for configurable Solr alias bootstrap migration.
Point API dependency locks at the OLD/ncbo_cron commits that keep the Solr alias status command read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the API test expectation for the Solr collection names returned by the search collections admin endpoint.
It aligns
ontologies_apiwith the Solr collection naming changes introduced in the relatedgooandontologies_linked_dataPRs.Prerequisites
This PR depends on the following upstream changes:
What Changed
Updated the expected collection names in:
test/controllers/test_search_models_controller.rbSpecifically:
term_search_core1->term_searchprop_search_core1->property_searchWhy
The previous test still expected the legacy physical collection names that used
*_core1terminology.This PR updates the test to match the new physical collection names used by the alias-backed Solr search model.
Related
The operational rebuild and cutover workflow for these collections is introduced in: