[NAV#707] Fix SC unit tests to work with large SC_PACKET_MAX_SIZE#171
Closed
thesamprice wants to merge 1 commit into
Closed
[NAV#707] Fix SC unit tests to work with large SC_PACKET_MAX_SIZE#171thesamprice wants to merge 1 commit into
thesamprice wants to merge 1 commit into
Conversation
- SC_LoadAts_Test_AtsEntryOverflow: Use fixed 256-byte message size to prevent stack buffer overflow - SC_UpdateAppend_Test_CmdDoesNotFitBuffer: Use dynamic values based on MaxBufEntries - SC_UpdateAppend_Test_EndOfBuffer: Fix word count calculation for variable-sized entries These fixes make the tests robust against SC_PACKET_MAX_SIZE values up to 4096 bytes. All 150 unit tests now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes make the tests robust against SC_PACKET_MAX_SIZE values up to 4096 bytes. All 150 unit tests now pass.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)