Skip to content

Fix cFS/cFS#686, Merge v7.0.1 Internal Updates #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jphickey merged 1 commit into from
Apr 30, 2026
Merged

Fix cFS/cFS#686, Merge v7.0.1 Internal Updates #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fsw/src/cs_table_processing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@
/* Helper function to split the App.Table name pattern */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void CS_ExtractNames(const CS_Def_Tables_Table_Entry_t *DefEntry,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
char *AppBuf,
size_t AppSz,
char *TableBuf,
Expand Down Expand Up @@ -588,13 +588,13 @@

TableNameLen -= AppNameLen;

if (AppNameLen > AppSz)
if (AppNameLen >= AppSz)
{
AppNameLen = AppSz;
AppNameLen = AppSz - 1;
}
if (TableNameLen > TableSz)
if (TableNameLen >= TableSz)
{
TableNameLen = TableSz;
TableNameLen = TableSz - 1;
}

memcpy(AppBuf, DefEntry->Name, AppNameLen);
Expand Down Expand Up @@ -809,7 +809,7 @@
* table, and obtain the address.
*
*-----------------------------------------------------------------*/
CFE_Status_t CS_RegisterDefinitionTable(CS_TableWrapper_t *tw,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
const char *DefinitionTableFileName,
CFE_TBL_CallbackFuncPtr_t CallBackFunction)
{
Expand Down Expand Up @@ -861,7 +861,7 @@
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t
CS_TableInit(CS_TableWrapper_t *tw, const char *DefinitionTableFileName, CFE_TBL_CallbackFuncPtr_t CallBackFunction)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
{
CFE_Status_t Result;

Expand Down
Loading