Fix binary128 MJD strings and document Apple Silicon containers - #2025
Open
vhaasteren wants to merge 6 commits into
Open
Fix binary128 MJD strings and document Apple Silicon containers#2025vhaasteren wants to merge 6 commits into
vhaasteren wants to merge 6 commits into
Conversation
Document Apple Silicon via native linux/arm64 containers (ng20) instead of Rosetta-only guidance, and size MJD string formatting to the platform longdouble precision so precision tests pass with IEEE binary128.
vhaasteren
changed the title
Binary-convert TASC↔T0 roundtrips and START/FINISH par reads keep more precision than float64/80-bit assumptions; compare within ~1 float64 ulp instead of requiring bit-identical Time/longdouble values.
…ix/precision Reconcile remote master merge with local binary128 MJD test fixes.
vhaasteren
changed the title
vhaasteren
added
the
awaiting review
Contributor
|
I think this is looking good (& helpful). Is it done? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux/arm64containers (e.g.nanograv/ng20) at native speed; keep Rosetta/osx-64as a slower alternative; add succinctpintk/X11 usage.numpy.longdoubleprecision, and widen the vectorize string dtype (wasU30), so precision tests pass on IEEE binary128 (Linux aarch64).float128on aarch64 Linux vsfloat64-aliased macOS ARM.convert_binaryroundtrips: stop requiring bit-identicalTime/MJD equality for TASC/T0 (propagation usesuncertainties/float64; sub-ns residuals show up under binary128).START/FINISHpar-file checks: compare againstnp.longdoubledigit strings with a ~1 float64-ulp tolerance (MJDParameter stores via jd1/jd2; Pythonfloatliterals truncate).Fixes #2024
Test plan
pytest tests/test_precision.pyonlinux/arm64— 91 passed, 6 xfailedtests/test_utils.pyMJD/longdouble caseslinux/arm64:pytest tests/test_binconvert.py::test_ELL1_roundtrip \ tests/test_binconvert.py::test_ELL1_roundtripFB0 \ tests/test_binconvert.py::test_DD_roundtrip \ tests/test_binconvert.py::test_DDFB0_roundtrip \ tests/test_parameters.py::TestParameters::test_start_finish_in_par -qlongdoublepath unchanged in spirit; digit count stays ≥ 16)