Add support for linking against wolfSSL provided by wolfssl-sys#45
Open
pulsastrix wants to merge 5 commits into
Open
Add support for linking against wolfSSL provided by wolfssl-sys#45pulsastrix wants to merge 5 commits into
pulsastrix wants to merge 5 commits into
Conversation
Workflow Status ReportGenerated for commit 18a3214 on Sat Jul 12 10:02:36 UTC 2025.
In case of failure, clippy warnings and rustfmt changes (if any) will be indicated as CI check warnings in the file comparison view. Documentation: Read Online Download Coverage Report: Read Online Download Note: Online versions of documentation and coverage reports may not be available indefinitely, especially after the pull request was merged. Code Coverage ReportCoverage target is 80%. Expand to view coverage statistics |
JKRhb
approved these changes
Mar 3, 2025
JKRhb
left a comment
JKRhb
left a comment
Member
There was a problem hiding this comment.
Just stumbled upon two tiny spots, otherwise LGTM :)
pulsastrix
commented
Mar 3, 2025
| openssl-sys = { version = "^0.9.74", optional = true } | ||
| mbedtls-sys-auto = { version = "^2.26", optional = true } | ||
| tinydtls-sys = { version = "^0.2.0", default-features = false, optional = true } | ||
| wolfssl-sys = { version = "2.0.0", git = "https://github.com/namib-project/wolfssl-rs.git", branch = "add_sys_cargo_metadata", optional = true, features = ["aesccm", "hmac", "psk", "opensslall", "ex_data", "alpn", "dh"] } |
Member
Author
There was a problem hiding this comment.
I'll leave this comment here to make sure that we don't merge this until the required changes to wolfssl-sys have been upstreamed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the vendored version of
libcoapto link against the version of wolfSSL that is used by thewolfssl-syscrate.This change required some modifications to
wolfssl-sysin order to expose the library paths to us and enable features necessary for libcoap, which is why it currently uses our own fork ofwolfssl-sys.Closes #29.