-
-
Notifications
You must be signed in to change notification settings - Fork 339
Update dependencies #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabaindaiz
wants to merge
8
commits into
museofficial:master
Choose a base branch
from
fabaindaiz:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update dependencies #1279
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
03b50b4
feat update dependences
fabaindaiz 8aaff97
actions update target iamge
fabaindaiz 36304c0
fix typecheck
fabaindaiz b1e844c
fix lint and actions
fabaindaiz ccb8cfd
fix lint
fabaindaiz 4cf68ed
Revert "actions update target iamge"
fabaindaiz b6556dd
feat update dependencies
fabaindaiz 07812ed
fix: update Husky configuration to v9 format
fabaindaiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import js from '@eslint/js'; | ||
| import typescript from '@typescript-eslint/eslint-plugin'; | ||
| import tsParser from '@typescript-eslint/parser'; | ||
|
|
||
| export default [ | ||
| js.configs.recommended, | ||
| { | ||
| files: ['src/**/*.{ts,tsx}'], | ||
| languageOptions: { | ||
| parser: tsParser, | ||
| parserOptions: { | ||
| ecmaVersion: 2020, | ||
| sourceType: 'module', | ||
| project: './tsconfig.json', | ||
| }, | ||
| }, | ||
| plugins: { | ||
| '@typescript-eslint': typescript, | ||
| }, | ||
| rules: { | ||
| // Rules from package.json eslintConfig | ||
| 'new-cap': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| '@typescript-eslint/prefer-readonly-parameter-types': 'off', | ||
| '@typescript-eslint/no-implicit-any-catch': 'off', | ||
|
|
||
| // Basic rules | ||
| 'no-unused-vars': 'off', | ||
| 'no-undef': 'off', // TypeScript handles this | ||
| 'prefer-const': 'warn', | ||
| 'no-var': 'error', | ||
| }, | ||
| }, | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| import {AutocompleteInteraction, ChatInputCommandInteraction} from 'discord.js'; | ||||||
| import {URL} from 'url'; | ||||||
| import {SlashCommandBuilder, SlashCommandSubcommandsOnlyBuilder} from '@discordjs/builders'; | ||||||
| import {SlashCommandBuilder, SlashCommandSubcommandsOnlyBuilder, SlashCommandOptionsOnlyBuilder} from '@discordjs/builders'; | ||||||
| import {inject, injectable, optional} from 'inversify'; | ||||||
| import Spotify from 'spotify-web-api-node'; | ||||||
| import Command from './index.js'; | ||||||
|
|
@@ -13,7 +13,7 @@ import AddQueryToQueue from '../services/add-query-to-queue.js'; | |||||
|
|
||||||
| @injectable() | ||||||
| export default class implements Command { | ||||||
| public readonly slashCommand: Partial<SlashCommandBuilder | SlashCommandSubcommandsOnlyBuilder> & Pick<SlashCommandBuilder, 'toJSON'>; | ||||||
| public readonly slashCommand: Partial<SlashCommandBuilder | SlashCommandSubcommandsOnlyBuilder | SlashCommandOptionsOnlyBuilder> & Pick<SlashCommandBuilder, 'toJSON'>; | ||||||
|
|
||||||
| public requiresVC = true; | ||||||
|
|
||||||
|
|
@@ -75,11 +75,13 @@ export default class implements Command { | |||||
|
|
||||||
| try { | ||||||
| // Don't return suggestions for URLs | ||||||
| // eslint-disable-next-line no-new | ||||||
| new URL(query); | ||||||
| await interaction.respond([]); | ||||||
| return; | ||||||
| } catch {} | ||||||
| } catch { | ||||||
|
||||||
| } catch { | |
| } catch (_error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Empty catch block should include a parameter name even if unused, as per TypeScript best practices. Consider
} catch (_error) {or} catch (error) {.