Skip to content

Update ytdl-core Dependency and Rebuild - #1221

Open
IvanMicai wants to merge 5 commits into
museofficial:masterfrom
IvanMicai:update-ytdl-core
Open

Update ytdl-core Dependency and Rebuild#1221
IvanMicai wants to merge 5 commits into
museofficial:masterfrom
IvanMicai:update-ytdl-core

Conversation

@IvanMicai

@IvanMicai IvanMicai commented Feb 9, 2025

Copy link
Copy Markdown

This PR updates ytdl-core to the latest version and rebuilds the project to ensure compatibility and stability.

✅ Changes

📌 Upgraded ytdl-core in package.json.
🔄 Rebuilt the project to integrate the update.

📢 Why?

⚡ Ensures continued compatibility with YouTube.
🛠️ Fixes potential bugs and improves performance.

🧪 Testing

🎵 Verified YouTube streaming works.
🛠️ Checked all related commands function correctly.
🚨 No new errors or warnings detected.

⚡ This update ensures seamless operation and prevents potential issues with YouTube’s service changes.

@codetheweb

codetheweb commented Feb 9, 2025

Copy link
Copy Markdown
Collaborator

📦 🤖 A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1221.

Images are available for x86_64 and ARM64.

Latest commit: 20c5dd2

@IvanMicai IvanMicai changed the title fix: update ytdl-core and build Update ytdl-core Dependency and Rebuild Feb 9, 2025
Comment thread Dockerfile Outdated
Comment thread package.json
"@discordjs/rest": "1.0.1",
"@discordjs/voice": "0.17.0",
"@distube/ytdl-core": "^4.15.9",
"@distube/ytdl-core": "^4.16.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you gander at #1195 and #1180

What is different exactly? It's been an issue for a few months now, and has a few of us... well stumped.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.
In my PR, I only upgraded the version of ytdl-core to get music downloads working again.
#1180 do the same, but I needed to update to version 4.16 because there were changes in the page's regex.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I update the node version to 20, to prevent some errors too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants