Skip to content

Conversation

@Wind4Greg
Copy link
Contributor

This PR adds SLH-DSA public keys from FIPS 205.

I tried to do this in the same manner as the ML-DSA keys added in PR #392.

The keys are for the different SLH-DSA variants are enumerated in Table 2 section 11 of FIPS 205 . There are twelve variants:

SLH-DSA-SHA2-128s, SLH-DSA-SHAKE-128s, SLH-DSA-SHA2-128f, SLH-DSA-SHAKE-128f, SLH-DSA-SHA2-192s, SLH-DSA-SHAKE-192s, SLH-DSA-SHA2-192f, SLH-DSA-SHAKE-192f, SLH-DSA-SHA2-256s, SLH-DSA-SHAKE-256s, SLH-DSA-SHA2-256f, SLH-DSA-SHAKE-256f

I picked a contiguous block of what seem to be unassigned codes. BR Greg

@rvagg
Copy link
Member

rvagg commented Jan 27, 2026

Thanks @Wind4Greg. You'll need to put these entries in order, where they belong in the 0x12xx section. Also note that the ML-DSA ones got added with -pub suffixes, which is the established pattern here—public keys get -pub. It looks like we also have ML-DSA private keys in 0x1313-0x1315, do we need to add them for SLH-DSA too?

@Wind4Greg
Copy link
Contributor Author

Hi @rvagg thanks for the quick response. I added the "-pub" suffix to all entries, and put them in order based on the code value. Hmm, I see the ML-KEM private keys at 0x1313-0x1315, but not the ML-DSA private keys. I could add them for consistency maybe starting with 0x1240-0x124b.

@rvagg
Copy link
Member

rvagg commented Jan 28, 2026

No need to add the private keys if you don't need them, they could be added later by someone that has a need for them, or perhaps nobody if they are never needed. There'll be space for them.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pushed a newline char at EOF)

@rvagg rvagg merged commit 5867f29 into multiformats:master Jan 28, 2026
1 check passed
@Wind4Greg
Copy link
Contributor Author

Thanks @rvagg! I'll be back when FALCON gets turned into FIPS-206. These codes are going into the Verifiable Credential cryptosuite for PQC. Cheers Greg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants