Impls #1792 adds an ability to reopen current tab in the specific container with a shortcut

[antondudakov]

Before submitting your pull request

• I agree to license my code under the MPL 2.0 license.
• I rebased my work on top of the main branch.
• I ran npm test and all tests passed.
• I added test coverages if relevant.

Description

Issue #1792

Type of change

Select all that apply.

• Bug fix
• New feature
• Major change (fix or feature that would cause existing functionality to work differently than in the current version)

reopen.in.container.with.shortcut.mov

PR to localization: mozilla-l10n/multi-account-containers-l10n#31

[antondudakov]

Hey, guys.
Can I have a review, please?
@dannycolin
@groovecoder
@rafeerahman

[antondudakov]

Hey, guys.
Can I have a review, please?
@dannycolin
@groovecoder
@rafeerahman

😭😭😭
Can we have this?

[antondudakov]

Hey, guys.
Can I have a review, please?
@dannycolin
@groovecoder
@rafeerahman

😭😭😭 Can we have this?

@lesleyjanenorton

[achernyakevich-sc]

Hey, guys.
Can I have a review, please?
@dannycolin
@groovecoder
@rafeerahman

😭😭😭 Can we have this?

@lesleyjanenorton

@antondudakov this is open source and sometimes people just have no time to pay attentions because completely overloaded on their regular job.

What I could advise to increase chances for faster review and acceptance of PR:

• implement only functionality that you would like to get: less code to review - easier to review and bigger chance to be reviewed.
• if you would like to have code refactored - create separate PR: less code to review and with no new functionality - easier to review and bigger chance to be reviewed.
• create a GitHub Issue that will describe what is the feature and how it will work, sometimes discussion in the issue result to completely different direction of feature implementation than initially it was expected.

[antondudakov]

Hey, guys.
Can I have a review, please?
@dannycolin
@groovecoder
@rafeerahman

😭😭😭 Can we have this?

@lesleyjanenorton

@antondudakov this is open source and sometimes people just have no time to pay attentions because completely overloaded on their regular job.

What I could advise to increase chances for faster review and acceptance of PR:

* implement only functionality that you would like to get: less code to review - easier to review and bigger chance to be reviewed.

* if you would like to have code refactored - create separate PR: less code to review and with no new functionality - easier to review and bigger chance to be reviewed.

* create a GitHub Issue that will describe what is the feature and how it will work, sometimes discussion in the issue result to completely different direction of feature implementation than initially it was expected.

This is exactly what I did.

1. The code that implement feature is just around 50 lines of code;
2. it's not a refactoring;
3. There's an issue Keyboard shortcut for "Reopen this site in" #1792, I also mentioned my PR in comments in the issue

[antondudakov]

Hey @achernyakevich-sc, I hope you're doing well.
Could you provide a review, please? I've addressed all your comments. 🙏🥹

[antondudakov]

@achernyakevich-sc, if you have a spare minute, please review. All addressed

[antondudakov]

Hey, @bakulf, can you give feedback on this PR as well? I would really appreciate it.

[antondudakov]

Hey, @dannycolin , I really appreciate the feedback you gave. I applied it and the ready for the next round.
@bakulf if you can join the review and even merge it to have this small feature in the next release I would so happy, you can't even imagine