Skip to content

Remove GET /scanner/results/ endpoint#24543

Merged
willdurand merged 1 commit intomasterfrom
rm-scanner-results-api
Mar 2, 2026
Merged

Remove GET /scanner/results/ endpoint#24543
willdurand merged 1 commit intomasterfrom
rm-scanner-results-api

Conversation

@willdurand
Copy link
Member

Refs mozilla/addons#16088


This removes the API code. Another patch will remove the false/true
positive logic related to this API endpoint.

@willdurand willdurand marked this pull request as ready for review February 27, 2026 12:35
version: ${{ inputs.version }}
run: |
make test_internal_routes_allowed
# test_internal_routes:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this for when we want to use internal_routes again (which might come up in the future)

@willdurand willdurand requested a review from eviljeff February 27, 2026 12:37
@eviljeff
Copy link
Member

Another patch will remove the false/true positive logic related to this API endpoint.

Can you expand on this?

@willdurand
Copy link
Member Author

willdurand commented Feb 27, 2026

Can you expand on this?

#24546 will remove the logic that I named "false/true positive logic", which was a way to triage scanner results in the past (for MAD). The API endpoint removed here was exposing some of that data, but I split the clean-ups in 2 different PRs to ease review.

@willdurand willdurand force-pushed the rm-scanner-results-api branch from 10d382c to 80a3d1f Compare March 2, 2026 07:38
@willdurand
Copy link
Member Author

(rebase)

@willdurand willdurand force-pushed the rm-scanner-results-api branch from 80a3d1f to af35502 Compare March 2, 2026 07:39
@willdurand willdurand merged commit 1271c53 into master Mar 2, 2026
44 checks passed
@willdurand willdurand deleted the rm-scanner-results-api branch March 2, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants