Update _common.scss to ensure the label for buttonPrimary is readable#1068
Open
anna-yeddi wants to merge 1 commit intomozilla:masterfrom
Open
Update _common.scss to ensure the label for buttonPrimary is readable#1068anna-yeddi wants to merge 1 commit intomozilla:masterfrom
anna-yeddi wants to merge 1 commit intomozilla:masterfrom
Conversation
Current green background color is too light to be used for the white label text - it provides just 2.5:1 in color contrast while 3:1 is the bare minimum for large text and 4.5:1 or more is recommended. Changing the mixin to use a slightly darker gray keeps the bright visual appearance of the button while also providing the white label text with sufficient color contrast (4.47:1) for better readability and accessibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current green background color is too light to be used for the white label text - it provides just 2.5:1 in color contrast while 3:1 is the bare minimum for large text and 4.5:1 or more is recommended. Changing the mixin to use a slightly darker gray keeps the bright visual appearance of the button while also providing the white label text with sufficient color contrast (4.47:1) for better readability and accessibility.