Conversation
dklawren
commented
Apr 17, 2025
dklawren
commented
- Updated to PHP 7.4.33 which is the last in the 7.x series.
- Build and install a recent 2.49 version of Git
- Removed building of iconv, curl, and mbstring as they are included in the PHP base image anyway.
…d install latest git from source
zzzeid
approved these changes
Apr 17, 2025
zzzeid
left a comment
zzzeid
left a comment
There was a problem hiding this comment.
lgtm, but maybe we should test it a little more before merging to confirm nothing here interferes with the existing git functionality. I'll be doing that on a separate branch for the next couple of days.
Author
|
Agreed. We can sit on this for a little while since you have a workaround. Also we can push this change to Phabricator-dev and test it there as well. |
cgsheeh
reviewed
Apr 24, 2025
| expat \ | ||
| freetype \ | ||
| g++ \ | ||
| git \ |
Member
There was a problem hiding this comment.
Should we remove this git install if we're installing it from source below?
Is there are way we could get the latest version from a package manger?
| && docker-php-ext-enable apcu \ | ||
| && pecl install zip-1.15.5 \ | ||
| && docker-php-ext-enable zip \ | ||
| && wget https://mirrors.edge.kernel.org/pub/software/scm/git/git-${GIT_VERSION}.tar.gz \ |
Member
There was a problem hiding this comment.
Could we put these install steps in a script so the Git install is a single line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.