MOSIP-44507 by dhanendra06 · Pull Request #288 · mosip/packet-manager

dhanendra06 · 2026-03-26T08:14:20Z

No description provided.

coderabbitai · 2026-03-26T08:14:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df552248-ea79-4b6b-a788-e970a294ba89

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

* Fixed the stream handling Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Updated the khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the logger Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * changed the khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * removed the logger Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Removed unused code Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Removed whitespace Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> --------- Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

…tting the packet (mosip#283) Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

* MOSIP-44507 (mosip#282) * Fixed the stream handling Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Updated the khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the logger Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * changed the khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * removed the logger Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Removed unused code Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Removed whitespace Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> --------- Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * removed the thread synchornization and removed dupplicate call for getting the packet Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * MOSIP-44507 Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the schema validation Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the /biometric endpoint issue taking longer time to respond Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the cache issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the cache issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the cache issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Added cache Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Added cache Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * removed cache Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * removed cache changes Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the loggers Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Added logger in decrypt method Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * modified ziputils Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * packetreaderservice Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed securitycontext issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Reverted packetreader service Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the /info endpoint Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed /info endpoint slowness issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the /info endpoint Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed packetreaderservice slowness issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed packetreaderservice slowness issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Reverted packetreaderservice Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Reverted packetreaderimpl changes Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the /info endpoint slowness issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the packetreaderimpl Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * increased the performance of /info endpoint Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * increased the performance of /info endpoint Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * increased the performance of /info endpoint Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * reverted packetreader service impl changes Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Added back packet reader impl changes Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Made audit to async Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * reverted packet reader service Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Added virtual thread to improve the performance Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the Audit log entry Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed packet reader service info call performancee Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed packet reader service info call performancee Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed test case Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the executor to pass securitycontext Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed pod failing issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Reverted the config Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the performance issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed performance issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the executor issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the stability issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the search filed repeated s3 calls Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * updated khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Reverted the khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fix the validate request endpoint Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the validate endpoint performance Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the object serialization issue Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Updated khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * reverted khazana version Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * removed the loggers Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> * Fixed the build failure and removed the logger Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> --------- Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com> Signed-off-by: Dhanendra Sahu <60607841+dhanendra06@users.noreply.github.com> Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

…#285) Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

…#287) Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

Signed-off-by: Ashok Kumar Sharma <ashok@mosip.io>

ashok-ksharma · 2026-03-27T13:07:52Z

...et/commons-packet-manager/src/main/java/io/mosip/commons/packet/config/AuditAsyncConfig.java

+    @Bean(name = "auditTaskExecutor")
+    public ExecutorService auditTaskExecutor() {
+        auditPool = Executors.newFixedThreadPool(auditPoolSize,
+                Thread.ofPlatform().name("audit-", 0).daemon(true).factory());


We should not use the daemon threads because these threads get killed once the main thread is completed and JVM will not wait to finish these threads.

ashok-ksharma · 2026-03-27T13:14:12Z

...et/commons-packet-manager/src/main/java/io/mosip/commons/packet/config/AuditAsyncConfig.java

+    @Bean(name = "packetFetchExecutor")
+    public ExecutorService packetFetchExecutor() {
+        fetchPool = Executors.newFixedThreadPool(fetchPoolSize,
+                Thread.ofPlatform().name("pkt-fetch-", 0).daemon(true).factory());


We should not use the daemon threads because these threads get killed once the main thread is completed and JVM will not wait to finish these threads.

ashok-ksharma · 2026-03-27T13:15:32Z

...cket/commons-packet-manager/src/main/java/io/mosip/commons/packet/impl/PacketReaderImpl.java

+	@Value("${packetmanager.fetch.concurrency.limit:35}")
+	private int fetchConcurrencyLimit;
+
+	private Semaphore fetchSemaphore;


We need to check on this because it can restrict the overall packet processing underload because we are using the same semaphore multiple places.

ashok-ksharma · 2026-03-27T13:20:05Z

...cket/commons-packet-manager/src/main/java/io/mosip/commons/packet/impl/PacketReaderImpl.java


-		BIR cachedValue = cache.get(cacheKey, BIR.class);
-		if(cachedValue != null) {
+		byte[] cachedBytes = cache.get(cacheKey, byte[].class);


Why we have changed the caching logic. Previously we were caching the BIR not byte[] is being cached. We have two issues with this:

It can break the existing caching in redis because now cache data got changed.

We need to call CbeffValidator.getBIRFromXML(cachedBytes); during the cache hit which is unnecessary during the hot path.

ashok-ksharma · 2026-03-27T13:24:21Z

...cket/commons-packet-manager/src/main/java/io/mosip/commons/packet/impl/PacketReaderImpl.java

 			// biometric file not present in idobject. Search in meta data.
-			Map<String, String> metadataMap = getMetaInfo(id, source, process);
+			// Use facade's cached getMetaInfo() to avoid redundant S3 calls under high load.
+			Map<String, String> metadataMap = packetReader.getMetaInfo(id, source, process, false);


I feel this change is not required because in positive flow, we find the bioString and we may not get into this flow. Issue is:

While using this method, we are using the cached data which can cause issue.

ashok-ksharma · 2026-03-27T13:26:51Z

...acket/commons-packet-manager/src/main/java/io/mosip/commons/packet/util/PacketValidator.java

Same semaphore is used for concurrency control which may block the threads in peak load.

ashok-ksharma · 2026-03-27T13:41:07Z

...cket/commons-packet-manager/src/main/java/io/mosip/commons/packet/impl/PacketReaderImpl.java

+							// Faster than regex
+							if (str.length() >= 2 && str.charAt(0) == '"' &&
+									str.charAt(str.length() - 1) == '"') {
+								str = str.substring(1, str.length() - 1);
+							}


Please check this code is not equivalent to finalMap.putIfAbsent(key, value.toString().replaceAll("(^")|("$)", "")); Please check.

ashok-ksharma · 2026-03-27T13:43:50Z

...acket/commons-packet-manager/src/main/java/io/mosip/commons/packet/util/PacketValidator.java

+            Map<String, Object> objectMap = new HashMap<>();
+            for (String field : allFields) {
+                Object value = identityFields.get(field);
+                if (value == null) continue;
+                if (value instanceof String || value instanceof Number || value instanceof Boolean) {
+                    objectMap.put(field, value);
+                } else {
+                    objectMap.put(field, mapper.writeValueAsString(value));
+                }


In previous code, we were doing the conversion as dataType which is missing here : https://github.com/mosip/packet-manager/blob/v1.3.0/commons-packet/commons-packet-manager/src/main/java/io/mosip/commons/packet/impl/PacketReaderImpl.java#L142-L155

ashok-ksharma · 2026-03-27T15:28:20Z

...-service/src/main/java/io/mosip/commons/packetmanager/controller/PacketReaderController.java

+            // Fetch info once for source resolution; reuse across all fields
+            // to avoid N redundant S3 listObjectsV2 calls (one per field).
+            InfoResponseDto cachedInfo = packetReaderService.getInfoForSourceResolution(fieldDtos.getId());


Do we need this change because getSourceAndProcess() already calling packetReaderService.getInfoForSourceResolution(id); internally?

ashok-ksharma · 2026-03-28T06:46:44Z

As packet manager is being used as library. We need to validate whether packet manager library in reg client is also working fine as we have done lot of changes.

dhanendra06 and others added 6 commits March 26, 2026 13:44

removed the thread synchornization and removed dupplicate call for ge…

e3bfaec

…tting the packet (mosip#283) Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

Fixed performance issue under the load its not performing well (mosip…

dcedd44

…#285) Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

Fixed performance issue under the load its not performing well (mosip…

ea9bfa3

…#287) Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

removed the unused changes

753cf5b

Signed-off-by: Dhanendra Sahu <dhanendra.tech@gmail.com>

dhanendra06 force-pushed the MOSIP-054 branch from 0bbfebe to 753cf5b Compare March 26, 2026 08:14

[MOSIP-44507] Did some cleanup and fix.

668da0d

Signed-off-by: Ashok Kumar Sharma <ashok@mosip.io>

ashok-ksharma requested changes Mar 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MOSIP-44507#288

MOSIP-44507#288
dhanendra06 wants to merge 7 commits intomosip:release-1.3.xfrom
dhanendra06:MOSIP-054

dhanendra06 commented Mar 26, 2026

Uh oh!

coderabbitai bot commented Mar 26, 2026 •

edited

Loading

Review skipped

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma Mar 27, 2026

Uh oh!

ashok-ksharma commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dhanendra06 commented Mar 26, 2026

Uh oh!

coderabbitai bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashok-ksharma commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 26, 2026 •

edited

Loading