refactor(category): remove unused ms3_category_grid_fields and dead code#146
Open
Ibochkarev wants to merge 1 commit intobetafrom
Open
refactor(category): remove unused ms3_category_grid_fields and dead code#146Ibochkarev wants to merge 1 commit intobetafrom
Ibochkarev wants to merge 1 commit intobetafrom
Conversation
- Drop ms3_category_grid_fields logic from category/update controller - Simplify category page config (grid_fields, option_fields, product_fields removed) - Remove grid_fields branch from Product\GetList (only used with combo: true) - Remove unused $options property and options block from Product\GetList - Delete unused Processors\Category\GetList processor Fixes #145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Удалена неиспользуемая настройка
ms3_category_grid_fieldsи связанный с ней код. Настройка нигде не создаётся при установке, а грид товаров в категории давно переведён на Vue и берёт колонки изGridConfigService(API/api/mgr/grid-config/category-products).Изменения:
category/update: убрана логикаms3_category_grid_fields,grid_fields,option_fields,product_fields,option_keys; в конфиг страницы передаются только используемые поля (show_options,default_thumb,show_nested_products,category_products_rowsи т.д.).Processors\\Product\\GetList: удалена ветка сms3_category_grid_fieldsи опциями (процессор вызывается только сcombo: trueиз ms3.combo.js); удалены мёртвые$optionsи блок вprepareArray().Processors\\Category\\GetList(нигде не вызывается).Поведение страницы категории и комбо выбора товара не меняется.
Тип изменений
Связанные Issues
Fixes #145
Как это было протестировано?
Чеклист