Skip to content

Hide dotfiles from instance content scanning #5999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acorsicanfrog wants to merge 5 commits into
base: main
Choose a base branch
from
+27 −4
Open

Hide dotfiles from instance content scanning #5999

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
849fe4e
Hide dotfiles from instance content scanning
acorsicanfrog May 5, 2026
abc6cf5
Whitelist scannable instance content files
acorsicanfrog May 5, 2026
418e4f2
Merge branch 'main' into patch-1
acorsicanfrog May 6, 2026
8af43e5
Merge branch 'main' into patch-1
acorsicanfrog May 7, 2026
3c6fadf
Merge branch 'main' into patch-1
acorsicanfrog May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions packages/app-lib/src/state/profiles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,25 @@
cache_key: String,
}

fn is_scannable_project_file(
project_type: ProjectType,
file_name: &str,
) -> bool {
let Some(extension) = Path::new(file_name.trim_end_matches(".disabled"))
.extension()
.and_then(|ext| ext.to_str())
else {
return false;
};

match project_type {
ProjectType::Mod => extension.eq_ignore_ascii_case("jar"),
ProjectType::DataPack
| ProjectType::ResourcePack
| ProjectType::ShaderPack => extension.eq_ignore_ascii_case("zip"),
}
}

impl Profile {
pub async fn get(
path: &str,
Expand Down Expand Up @@ -648,8 +667,10 @@
&& let Some(file_name) = subdirectory
.file_name()
.and_then(|x| x.to_str())
&& !(project_type == ProjectType::ShaderPack
&& file_name.ends_with(".txt"))
&& is_scannable_project_file(
project_type,
file_name,
)
{
let file_size = subdirectory
.metadata()
Expand Down Expand Up @@ -1049,11 +1070,13 @@
{
let subdirectory =
subdirectory.map_err(io::IOError::from)?.path();
if subdirectory.is_file()

Check warning on line 1073 in packages/app-lib/src/state/profiles.rs

View workflow job for this annotation

GitHub Actions / Lint and Test 

Diff in /home/runner/work/code/code/packages/app-lib/src/state/profiles.rs
&& let Some(file_name) =
subdirectory.file_name().and_then(|x| x.to_str())
&& !(project_type == ProjectType::ShaderPack
&& file_name.ends_with(".txt"))
&& is_scannable_project_file(
project_type,
file_name,
)
{
let file_size = subdirectory
.metadata()
Expand Down
Loading