29 26 13 9 7 1 himanshu - #322
Open
HIMANSHU-SHARMA-1 wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented fixes for all of my assigned qualification issues.
What was changed
Testing
I tested the changes locally by going through the related workflows.
node -c index.js.Checklist
cd client && npm run lint && npm run buildandcd server && npm run lint && npm run buildlocallyShort Demo Video (required)
Required Checklist
Task & Workflow
masterbranch before opening this PR.Quality & Safety
Screenshots
Attached screenshots covering:
Screenshots
1. Empty Task Validation (#9)
Creating a task without the required fields now shows a validation message instead of allowing an invalid task to be created.
2. Duplicate Submission Prevention (#1)
Submitting the same task again after it has already been submitted displays an error and prevents the existing submission from being overwritten.
3. Request Revision Workflow (#13)
An admin can review a submission and request changes instead of only approving or rejecting it.
4. Revision Requested Status (#13)
After requesting a revision, the submission status is updated to Revision Requested in the admin submissions table.
5. Talent Re-submission Flow (#13)
The assigned talent can see the Revision Requested status and use the Re-submit button to upload an updated submission.
6. Re-submit Modal (#13)
The re-submit action opens the submission modal again, allowing the talent to upload a new file and notes.
7. Delete Confirmation (#26)
A confirmation dialog is displayed before deleting a task.
8. Reject Confirmation (#26)
A confirmation dialog is displayed before rejecting a submission.
9. Avatar Fallback (#29)
Verified that when a user avatar is unavailable, the reusable Avatar component displays the user's initials instead of a broken image.