Skip to content

29 26 13 9 7 1 himanshu - #322

Open
HIMANSHU-SHARMA-1 wants to merge 8 commits into
modelsuite-ai:masterfrom
HIMANSHU-SHARMA-1:29-26-13-9-7-1-himanshu
Open

29 26 13 9 7 1 himanshu#322
HIMANSHU-SHARMA-1 wants to merge 8 commits into
modelsuite-ai:masterfrom
HIMANSHU-SHARMA-1:29-26-13-9-7-1-himanshu

Conversation

@HIMANSHU-SHARMA-1

Copy link
Copy Markdown

Summary

Implemented fixes for all of my assigned qualification issues.

What was changed

  • Prevented duplicate task submissions while preserving the revision workflow.
  • Added authorization checks to prevent unauthorized access to task details.
  • Added support for the "Revision Requested" review state and updated the resubmission flow.
  • Replaced repeated avatar implementations with a reusable Avatar component that falls back to user initials when an image is unavailable.
  • Added confirmation dialogs before destructive actions such as delete and reject.
  • Added validation to prevent creating tasks with empty required fields.

Testing

I tested the changes locally by going through the related workflows.

  • Verified duplicate submissions are blocked unless a revision has been requested.
  • Verified the Request Revision → Re-submit → Pending workflow.
  • Confirmed unauthorized users cannot access task details that are not assigned to them.
  • Verified avatar fallback is displayed correctly.
  • Confirmed confirmation dialogs appear before destructive actions.
  • Successfully ran the frontend production build.
  • Successfully ran the server lint check.
  • Verified server syntax using node -c index.js.

Checklist

Required before opening this PR: Complete these checks locally to ensure the code is ready for review. PRs opened without these checks passing may be closed.

  • [✓ ] I ran cd client && npm run lint && npm run build and cd server && npm run lint && npm run build locally
  • [✓] All checks passed (lint, build)
  • [✓ ] No errors or warnings remain

Note: This is a pre-PR checklist completed before submission. Additional checklists below are completed after the PR is opened.

Short Demo Video (required)

https://drive.google.com/file/d/1gsdQDHyNIudA-PjeBWZ2ul1vFwyvEzn2/view?usp=drive_link


  • I have read and followed the Contribution and Qualification Guidelines

Required Checklist

Task & Workflow

  • [✓] Created a branch matching my assigned name.
  • [✓] PR title exactly matches my assigned branch name.
  • [✓] Pulled the latest master branch before opening this PR.

Quality & Safety

  • [✓] Changes tested locally.
  • [✓] Reviewed the full diff before submission.
  • [✓] No secrets, API keys, or personal data are included.

Screenshots

Attached screenshots covering:

Screenshots

1. Empty Task Validation (#9)

Creating a task without the required fields now shows a validation message instead of allowing an invalid task to be created.

bd6dee0c-6aeb-4114-90e5-f576df65b600

2. Duplicate Submission Prevention (#1)

Submitting the same task again after it has already been submitted displays an error and prevents the existing submission from being overwritten.

bd7b5406-35ad-4616-88ea-41685624977c

3. Request Revision Workflow (#13)

An admin can review a submission and request changes instead of only approving or rejecting it.

f00ffb93-1097-4e51-b2a0-ce42ea6c8818

4. Revision Requested Status (#13)

After requesting a revision, the submission status is updated to Revision Requested in the admin submissions table.

ffc26adf-1042-4589-8136-c49065d37f8c

5. Talent Re-submission Flow (#13)

The assigned talent can see the Revision Requested status and use the Re-submit button to upload an updated submission.

730f9bc7-9394-485a-b754-df7911587835

6. Re-submit Modal (#13)

The re-submit action opens the submission modal again, allowing the talent to upload a new file and notes.

bd7b5406-35ad-4616-88ea-41685624977c

7. Delete Confirmation (#26)

A confirmation dialog is displayed before deleting a task.

6ba17339-d257-47ac-add5-a4f57a1f96d3

8. Reject Confirmation (#26)

A confirmation dialog is displayed before rejecting a submission.

cebbaa05-09c1-4639-a604-295321e09375

9. Avatar Fallback (#29)

Verified that when a user avatar is unavailable, the reusable Avatar component displays the user's initials instead of a broken image.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant