Skip to content

fix: complete assigned issues #2 #6 #7 #13 #16 #17 - #255

Open
Shreya-Wani wants to merge 7 commits into
modelsuite-ai:masterfrom
Shreya-Wani:17-16-13-7-6-2-shreya-dilip-wani
Open

fix: complete assigned issues #2 #6 #7 #13 #16 #17#255
Shreya-Wani wants to merge 7 commits into
modelsuite-ai:masterfrom
Shreya-Wani:17-16-13-7-6-2-shreya-dilip-wani

Conversation

@Shreya-Wani

Copy link
Copy Markdown

Completed Issues

Closes #2
Closes #6
Closes #7
Closes #13
Closes #16
Closes #17

Changes Made

#2 - Task Assignment Validation

  • Prevented tasks from being assigned to Admin users
  • Added server-side role validation

#6 - Session Invalidation

  • Added server-side session/token invalidation on logout
  • Prevented reuse of logged-out tokens

#7 - IDOR Protection

  • Added authorization checks for task details API
  • Prevented unauthorized access to other users' tasks

#13 - Request Revision Workflow

  • Added "Request Revision" review state
  • Updated submission workflow and UI

#16 - Loading Indicators

  • Added loading states for critical actions
  • Prevented duplicate submissions during API requests

#17 - Toast Notifications

  • Replaced native browser alerts with toast notifications
  • Improved user feedback and UX

Testing

  • Verified task assignment restrictions
  • Verified logout invalidates active sessions
  • Verified task authorization checks
  • Verified request revision flow
  • Verified loading indicators
  • Verified toast notifications

@Pranav140

Copy link
Copy Markdown
Contributor

❌ The automated checks for this submission have failed.

As outlined in the instructions, you were expected to run npm run lint locally before submitting; however, the current failures indicate that this step was either missed or the reported issues were not addressed prior to submission.

Further evaluation will be based on code quality, adherence to best practices, and the improvements made beyond simply getting the checks to pass.

@Shreya-Wani

Copy link
Copy Markdown
Author

❌ The automated checks for this submission have failed.

As outlined in the instructions, you were expected to run npm run lint locally before submitting; however, the current failures indicate that this step was either missed or the reported issues were not addressed prior to submission.

Further evaluation will be based on code quality, adherence to best practices, and the improvements made beyond simply getting the checks to pass.

@Pranav140 I've pushed the CI fixes, could you please approve the workflow run?

@Shreya-Wani Shreya-Wani left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranav140 I've pushed the CI fixes, could you please approve the workflow run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment