Do not lazy load CompilingEvaluator#21
Open
soee wants to merge 1 commit into
Open
Conversation
mhsdesign
approved these changes
Apr 30, 2024
mhsdesign
left a comment
mhsdesign
left a comment
There was a problem hiding this comment.
Oddd ... that should be also a problem in 8 and 7 ...
|
Hmm, I use it in Neos 7 and 8 and have no issues. |
|
The fusion runtime also has to do this since ages as this is imo not a regression but a well known flaw which is also documented: see |
|
After upgrading to Neos 9, I'm getting the same exception. But only for some images it seems. I too didn't experienced this problem in Neos 7/8. Is there any update for this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Neos 9 we have exception thrown due to wrong argument type when caliing
Utility::evaluateEelExpression().The expected type is
EelEvaluatorInterfacebut the unresolved dependency injection is used instead.This commit marks the
eelEvaluatorpropery as not be lazy loaded while injecting.