FIX: correct mode parameter in get_point_spread and get_cross_talk#13754
Open
Famous077 wants to merge 4 commits intomne-tools:mainfrom
Open
FIX: correct mode parameter in get_point_spread and get_cross_talk#13754Famous077 wants to merge 4 commits intomne-tools:mainfrom
Famous077 wants to merge 4 commits intomne-tools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixed issue #13128
What does this implement/fix?
Found a bug where the
modeparameter inget_point_spread()andget_cross_talk()wasn't working as documented. The public API says'max'and'svd'are valid modes, but the internal helper function_summarise_psf_ctfuses different names ('maxnorm'and'pca'),so passing
'max'or'svd'just silently returned all verticeswithout any summarisation — no error, no warning.
Changes made:
ValueError_summarise_psf_ctfAdditional information
Verified the fix works correctly with both individual vertex indices and labels.
All 3 existing tests pass after the changes.