Skip to content

ENH: Add variance regularization to F-statistic in f_oneway#13698

Open
Aniketsy wants to merge 5 commits intomne-tools:mainfrom
Aniketsy:fix-11385
Open

ENH: Add variance regularization to F-statistic in f_oneway#13698
Aniketsy wants to merge 5 commits intomne-tools:mainfrom
Aniketsy:fix-11385

Conversation

@Aniketsy
Copy link
Contributor

@Aniketsy Aniketsy commented Feb 26, 2026 •
edited
Loading

Fixes #11385

@Aniketsy
Copy link
Contributor Author

Aniketsy commented Mar 13, 2026

@larsoner gentle ping, could you please review these changes when you have a chance? Thanks!

larsoner
larsoner reviewed Mar 13, 2026
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks reasonable to me

mne/stats/parametric.py
sigma : float
Regularization parameter (>= 0) added to the within-group mean
square to mitigate F-statistic inflation under low-variance
conditions. ``0`` (default) disables correction.
Copy link
Member

@larsoner larsoner Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs versionadded directives

Copy link
Contributor Author

@Aniketsy Aniketsy Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I'll update..

@Aniketsy
Copy link
Contributor Author

Aniketsy commented Mar 13, 2026

I'm seeing CI -doc failures in both of my PR's. From what I can tell, they seem unrelated to the changes in this PR

@drammock
Copy link
Member

drammock commented Mar 13, 2026

I'm seeing CI -doc failures in both of my PR's. From what I can tell, they seem unrelated to the changes in this PR

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://pandas.pydata.org/docs/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 522 Server Error: for url: https://pandas.pydata.org/docs/objects.inv

This might be a temporary network error, or might be a problem with Pandas' objects.inv file being missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner left review comments

@drammock drammock Awaiting requested review from drammock drammock is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow hat correction for f-tests

3 participants

@Aniketsy @drammock @larsoner