Segfault on gantry angle#993
Merged
Merged
Conversation
…s saved as FIFFT_FLOAT by MNE Python and as FIFFT_INT by mne-cpp
chdinh
approved these changes
May 7, 2026
chdinh
left a comment
chdinh
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! This is a real-world interop bug — MNE-Python writes FIFF_GANTRY_ANGLE as FIFFT_FLOAT while mne-cpp expected FIFFT_INT, leading to a segfault. The type-guarded dispatch is exactly the right fix. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segfault when opening FIF files saved from MNE Python. Gantry angle is saved as FIFFT_FLOAT by MNE Python and as FIFFT_INT by mne-cpp.