Replace runtime validation asserts#108
Open
pragnyanramtha wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces runtime input-validation assert statements (which are skipped under python -O) with explicit ValueError checks, and adds regression tests to ensure the validations still trigger in optimized mode.
Changes:
- Replace
assert-based validation in selection range handling and convex-hull lat/lon dimension checks withValueErrorexceptions. - Replace config entrypoint
.yamlextension validationassertwith an explicitValueError. - Add/adjust tests to expect
ValueErrorand to exercise the config entrypoint underpython -O.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_selection.py | Updates selection tests to expect ValueError (and adds equal-bounds coverage). |
| tests/test_convex_hull_cropping.py | Adds a test ensuring mismatched lat/lon dims raise ValueError. |
| tests/test_config.py | Adds an optimized-mode (-O) subprocess test for rejecting non-.yaml config paths. |
| mllam_data_prep/ops/selection.py | Replaces selection asserts with explicit ValueError checks. |
| mllam_data_prep/ops/cropping.py | Replaces convex-hull coordinate dimension asserts with ValueError checks (plus minor formatting). |
| mllam_data_prep/config.py | Replaces .yaml extension assert with ValueError in the module entrypoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #101
Tests