Skip to content

Deniz/dc agent updates 1215 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzorlu wants to merge 4 commits into
base: dcagent
Choose a base branch
from
Open

Deniz/dc agent updates 1215 #13

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6740494
up
Dec 15, 2025
da8345c
wand shared
Dec 16, 2025
4aadbbc
reset
Dec 16, 2025
573fd2b
Merge branch 'dcagent' into deniz/dc_agent_updates_1215
dzorlu Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion skyrl-train/examples/terminal_bench/terminal_bench_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ async def terminal_bench_agent_loop(
"key": "fake_key",
"max_episodes": self.max_episodes,
"session_id": session_id,
"store_all_messages": True,
"enable_summarize": self.enable_summarize,
},
),
Expand All @@ -176,14 +177,15 @@ async def terminal_bench_agent_loop(
else:
raise ValueError(f"Invalid agent name: {self.agent_name}")

trial = Trial(trial_config)


# Run the trial to get `rewards`, `chat_history`, and `summarization_count`
successful = False
reward = None
chat_history = None
summarization_count = None
for i in range(MAX_NUM_RETRIES_PER_TRIAL):
trial = Trial(trial_config)
prefix = f"Trajectory {trajectory_id} attempt {i+1}/{MAX_NUM_RETRIES_PER_TRIAL}"
results = None
try:
Expand Down