Skip to content

modified for actix-web v4.1.0#23

Open
anosatsuk124 wants to merge 1 commit into
miquels:masterfrom
anosatsuk124:patched
Open

modified for actix-web v4.1.0#23
anosatsuk124 wants to merge 1 commit into
miquels:masterfrom
anosatsuk124:patched

Conversation

@anosatsuk124

Copy link
Copy Markdown

I have updated impl actix_web::Responder for DavResponse for actix-web v4.1.0 and passed a build with default and actix-compat features.

@anosatsuk124 anosatsuk124 changed the title modifed for actix-web v4.1.0 modified for actix-web v4.1.0 Jul 3, 2022
@LinusCDE

Copy link
Copy Markdown

Tested it. It seems that DavRequest::prefix(&self) doesn't recognize the path properly. For some reason the HttpRequest::match_info(&self) doesn't return the {tail:.*} identifier for me. match_name() is also an empty string for me.

Here, the variable path is empty for me. Using req.path() fixes that. But tail also is always empty, so the prefix cannot be calculated anyway.

Taking the left handside of a { using the string from match_pattern() seems to give the intended prefix, but is a dirty workaround imo.

Either there is a new proper way of doing it now or my setup has some weird thing going on that breaks this check. Would be interesting to know if it's just me or affecting others as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants