fix(cli): prevent flash of raw composition content before runtime mounts - #3
Open
watanabefam wants to merge 3 commits into
Open
fix(cli): prevent flash of raw composition content before runtime mounts#3watanabefam wants to merge 3 commits into
watanabefam wants to merge 3 commits into
Conversation
The chat auto-scrolled to the bottom on every message render, making it impossible to scroll up and read earlier messages while the conversation was ongoing. Now only auto-scrolls if the user is within 60px of the bottom. If they've scrolled up to read history, their position is respected.
…or reliable scroll justify-content: flex-end causes inconsistent scrollTop behavior across browsers when combined with overflow-y: auto. Replaced it with margin-top: auto on the inner container, which pushes messages to the bottom naturally while keeping scroll position math consistent. Also added overflow-x: hidden, overscroll-behavior: contain, and scroll-behavior: smooth for a more reliable scroll experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stripFallback function removed CSS rules referencing [data-erp-fallback], which included the
:not([data-erp-fallback])rule that hides raw content. This caused a flash of unstyled XML before the runtime mounted.Now preserves the
:not(...)rule and adds a generic 'edu-role-play > * { display: none !important; }' rule to hide all raw content until the runtime creates the shadow DOM.