Skip to content

✨ Add support for all utility models#301

Open
ianardee wants to merge 9 commits intomainfrom
utilities
Open

✨ Add support for all utility models#301
ianardee wants to merge 9 commits intomainfrom
utilities

Conversation

@ianardee
Copy link
Collaborator

Description

Add support for all utility type models.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@ianardee ianardee changed the title add classification classes ✨ add support for all utility models Mar 12, 2026
@ianardee ianardee changed the title ✨ add support for all utility models ✨ Add support for all utility models Mar 12, 2026
@ianardee ianardee force-pushed the utilities branch 3 times, most recently from da3b846 to 7093d27 Compare March 12, 2026 16:43
@ianardee ianardee force-pushed the utilities branch 6 times, most recently from 3deefaa to 686970f Compare March 13, 2026 14:37
@ianardee ianardee marked this pull request as ready for review March 13, 2026 14:43
Copy link
Collaborator

@sebastianMindee sebastianMindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the nasty warning in smoke tests?

Note: Annotation processing is enabled because one or more processors were found
on the class path. A future release of javac may disable annotation processing
unless at least one processor is specified by name (-processor), or a search
path is specified (--processor-path, --processor-module-path), or annotation
processing is enabled explicitly (-proc:only, -proc:full).
Use -Xlint:-options to suppress this message.
Use -proc:none to disable annotation processing.

This one^

Comment on lines +46 to +48
if (pollingOptions.getMaxRetries() < 2) {
throw new IllegalArgumentException("Max retries must be ≥ 2");
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason to prevent 1 as a value here?


// Send for processing
InferenceResponse response = mindeeClient.enqueueAndGetInference(
InferenceResponse response = mindeeClient.enqueueAndGetResult(
Copy link
Collaborator

@sebastianMindee sebastianMindee Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you implement an ExtractionResponse and ExtractionParameters wrapper for this class like I did for Ruby, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants