Testability#2
Open
d--j wants to merge 8 commits into
Open
Conversation
…ry users can check against to detect error conditions Library users could e.g. use ErrHashInvalid to cycle through a list of secrets key to allow secret key rollover.
the test cases are mainly the test cases from PostSRSd's blackbox test
the SRS1 address handling is consistent with Mail::SRS's implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the test so that it will work with a "fake" time. Eliminates the need for setting up a PostSRSd for testing.
The test cases are from PostSRSd's blackbox test
Since this library did not pass all of the PostSRSd test (that it should, some are specific to PostSRS and I skipped those), this PR also makes the SRS0/1 address parsing for foreign SRS0/1 addresses more lenient.
I tried to make the commits as small as possible – you might want to review the commits one-by-one to more easily follow the changes.