fix: coverage without opt-in + real linter e2e test#14
Merged
Conversation
Coverage: `bazel coverage` now works on ANY ts_test without requiring `coverage = True`. The runner detects COVERAGE_OUTPUT_FILE unconditionally (set by Bazel during `bazel coverage`). The `coverage` attr now only controls coverage during `bazel test`. Linting: Added oxlint to the npm lockfile and created tests/lint_real/ with a real oxlint binary test. The ts_lint rule is now verified end-to-end with actual lint violations detected by a real linter. Also fixed: npm_bin runner creates a temp node_modules with optional dep symlinks so native binaries (oxlint platform packages) resolve correctly. ts_lint uses absolute paths via captured EXECROOT. Fixes #10, #11. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test requires('typescript') which isn't in the main repo's lockfile.
On macOS CI where there's no global typescript, this crashes. Now skips
gracefully like the diagnostics test does.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bazel coveragenow works on ANYts_testwithout requiringcoverage = True. The runner detectsCOVERAGE_OUTPUT_FILEunconditionally.tests/lint_real/exercisests_lintwith a real oxlint binary — verifying actual lint violations are detected.Test plan
bazel coverage //tests/vitest:math_testproduces lcov (nocoverage = Trueneeded)bazel test //tests/lint_real:real_lint_testpasses with real oxlintbazel test //... --cache_test_results=no— 33/33 passFixes #10, #11.
🤖 Generated with Claude Code