feat(player): long-press gesture as Chapter / 2x Speed / Disabled#50
Merged
Conversation
Replaces the boolean chapter-skip toggle with a PreferenceSelect offering Skip chapter / 2x speed / Disabled, so the hold gesture can be turned off and its purpose is clearer. Implemented cleanly (not cherry-picked) from upstream PR jarnedemeulemeester#1119 by Rdkang: instead of storing translated display text as the persisted value, use our PreferenceSelect idiom with a separate display array and stable values (chapter/speed/disabled). Default is "chapter" to preserve the previous default behavior. Removed the now-unused player_gestures_chapter_skip strings across all locales. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the player long-press (hold) gesture from a boolean "chapter skip" toggle into a select: Skip chapter / 2x speed / Disabled. This lets users turn the hold gesture off entirely and makes the setting's purpose clearer.
Closes #49.
Attribution
Inspired by upstream PR jarnedemeulemeester/findroid#1119 by @Rdkang. Implemented cleanly rather than cherry-picked (the upstream branch is 10 commits with internal merges, and stores translated display text as the persisted value).
What's different from the upstream PR (cleanliness)
PreferenceSelectidiom with a separate display array (player_gestures_hold) and a stable values array (player_gestures_hold_values→chapter/speed/disabled), instead of persisting English UI text like"2x Speed". Localization-safe and robust to label changes.return—PlayerGestureHelperuses awhenthat simply has no branch fordisabled.chapter— preserves the previous default behavior (hold = skip chapter). The upstream PR changed the default to Disabled; flag if you'd prefer that.player_gestures_chapter_skipstrings across all 25 locales.Testing
:app:phone:compileLibreDebugKotlin✅