Skip to content

Network - 26883 - Default rule set is assigned in Azure Front Door WAF#1053

Open
aahmed-spec wants to merge 4 commits intodevfrom
dev-26883
Open

Network - 26883 - Default rule set is assigned in Azure Front Door WAF#1053
aahmed-spec wants to merge 4 commits intodevfrom
dev-26883

Conversation

@aahmed-spec
Copy link
Collaborator

made changes as per updated spec

@aahmed-spec aahmed-spec self-assigned this Mar 13, 2026
@aahmed-spec aahmed-spec marked this pull request as ready for review March 13, 2026 10:55
@peresys13 peresys13 requested a review from Copilot March 13, 2026 10:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ZeroTrustAssessment test 26883 (Azure Front Door WAF) to match the updated specification by evaluating additional policy conditions beyond just the presence of the default managed rule set.

Changes:

  • Updates the test Title text (“Default rule set …”) to match the updated spec wording.
  • Reworks ARG output handling to retrieve managedRuleSets as an object/array and evaluate default ruleset presence/version in PowerShell (instead of using string/regex extraction in KQL).
  • Expands pass/fail evaluation to include policy enabled state, WAF mode (Prevention), default ruleset assignment, and “not all rules disabled”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aahmed-spec aahmed-spec added the ready for review PR is ready for review and merging label Mar 13, 2026
Copy link
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aahmed-spec Please, address my feedback.

@aahmed-spec aahmed-spec requested a review from alexandair March 16, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is ready for review and merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants