Conversation
aahmed-spec
requested review from
SagarSathe,
alexandair,
merill and
tdetzner
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
Updates Network test 25395 to better report Entra Private Access application segmentation findings (least-privilege) by improving portal linking and adjusting Graph queries/error handling.
Changes:
- Added Entra portal link templates and used them in markdown output tables.
- Wrapped several Microsoft Graph queries in
try/catchwith warning logs and fallback values. - Tweaked report formatting (segment scope delimiter) and updated the accompanying markdown guidance text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/powershell/tests/Test-Assessment.25395.ps1 | Adds portal URL templates, changes Graph queries (filters + error handling), and adjusts markdown/table output formatting. |
| src/powershell/tests/Test-Assessment.25395.md | Refines description text to remove “Quick Access configurations” example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexandair
changed the title
alexandair
left a comment
alexandair
left a comment
There was a problem hiding this comment.
@aahmed-spec
No need for fallback API calls. Please, remove them.
Made changes. |
|
@alexandair and @aahmed-spec there are merge conflicts. Can you please fix? tx |
aahmed-spec
force-pushed
the
test-25395-bugfix
branch
from
ee5c2ff to
7765222
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix #747
BugFix
https://github.com/microsoft/ztspecs/issues/44
Spec